Skip to content

SourcePopover: Gtk4 prep, cleanup#853

Merged
danirabbit merged 2 commits into
masterfrom
danirabbit/sourcepopover-gtk4prep
Jul 23, 2025
Merged

SourcePopover: Gtk4 prep, cleanup#853
danirabbit merged 2 commits into
masterfrom
danirabbit/sourcepopover-gtk4prep

Conversation

@danirabbit

@danirabbit danirabbit commented Jul 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • Bump copyright header
  • Modern code style
  • Set listbox mode to BROWSE so screen reader doesn't read "not selected" for every row
  • Replace grids with boxes
  • Remove some weird stuff with height request. We already propagate natural height and set max content height, so it doesn't seem like this does anything. It's been kept around since 2013 when we had a hardcoded size request and no way to propagate natural height

@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Jul 22, 2025
@danirabbit
danirabbit requested a review from a team July 22, 2025 23:45
@danirabbit
danirabbit enabled auto-merge (squash) July 23, 2025 16:30
@danirabbit
danirabbit merged commit c756ebb into master Jul 23, 2025
6 checks passed
@danirabbit
danirabbit deleted the danirabbit/sourcepopover-gtk4prep branch July 23, 2025 16:31
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in GTK4 Porting Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardo-lemos leonardo-lemos leonardo-lemos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

GTK4 Porting
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danirabbit @leonardo-lemos