Skip to content

AgendaEventRow: make location link clickable#862

Merged
danirabbit merged 7 commits into
masterfrom
danirabbit/location-link
Nov 16, 2025
Merged

AgendaEventRow: make location link clickable#862
danirabbit merged 7 commits into
masterfrom
danirabbit/location-link

Conversation

@danirabbit

@danirabbit danirabbit commented Sep 13, 2025

Copy link
Copy Markdown
Member

Fixes #332

Also has the side effect of giving us nicer location titles sometimes

Screenshot from 2025-09-13 12 30 33

@danirabbit
danirabbit marked this pull request as ready for review September 13, 2025 19:29
@danirabbit
danirabbit requested a review from a team September 13, 2025 19:33
@danirabbit danirabbit added this to OS 9 Sep 13, 2025
@danirabbit danirabbit moved this to Needs Review in OS 9 Sep 13, 2025
@zeebok

zeebok commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

I am trying to test this locally with both a new and an existing event but when I try to do a search, for example Dallas, TX it never displays any kind of search results. If I open the event details and look at the map after adding the location, it just has the location pin in the middle of the ocean off of Africa. Maybe I am missing something either with dependencies or how to use this?

Additionally if I save to update an event I see 2 event entries until I restart the app (maybe this is an unrelated bug)

Nothing in your code looks out of place; in fact, it seems good to me.

@danirabbit

Copy link
Copy Markdown
Member Author

@zeebok I'm testing by adding a location in calendar events in my phone. I think adding locations in Calendar is currently broken :(

@danirabbit danirabbit mentioned this pull request Oct 30, 2025
1 task
@danirabbit danirabbit removed this from OS 9 Nov 4, 2025
@danirabbit danirabbit moved this to Needs review in OS 8.1.0 Nov 4, 2025

@zeebok zeebok left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good even if adding location is busted so I can't test

@danirabbit
danirabbit merged commit 4f6ae87 into master Nov 16, 2025
6 checks passed
@danirabbit
danirabbit deleted the danirabbit/location-link branch November 16, 2025 01:54
@github-project-automation github-project-automation Bot moved this from Needs review to Done in OS 8.1.0 Nov 16, 2025
@danirabbit danirabbit mentioned this pull request Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Get location titles

2 participants