EventMenu: use GLib.Action#869
Merged
Merged
Conversation
leolost2605
reviewed
Dec 22, 2025
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
LGTM, only a minor comment
| var action_edit = new GLib.SimpleAction ("edit", null); | ||
| action_edit.set_enabled (sensitive); | ||
| action_edit.activate.connect (() => { | ||
| ((Maya.Application) GLib.Application.get_default ()).window.on_modified (comp); |
Member
There was a problem hiding this comment.
Can we get the comp via an id or something like that? If so we could move the edit and duplicate actions to the window which would make it a bit cleaner I think
Member
Author
There was a problem hiding this comment.
I'm sure it's possible but I couldn't see any easy way to do it so I figured I'd leave a bigger refactoring for later. But I totally agree that would be a lot cleaner
leolost2605
approved these changes
Jan 14, 2026
danirabbit
enabled auto-merge (squash)
January 14, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GTK4 Prep. First step towards eventually using GLib.Menu instead of Gtk.Menu