App: Monitor the Desktop file to know when it has been removed #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differ the actual removal as this might be triggered by a file update.
…ion file Allow to add a launcher and it being taken into account.
danirabbit
reviewed
Jul 9, 2024
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Hm this doesn't actually seem to work for me. If the dock is restarted then it will remove the launcher but not while the dock is running
| break; | ||
| case GLib.FileMonitorEvent.DELETED: | ||
| exists = false; | ||
| removal_timer = GLib.Timeout.add_seconds (60, () => { |
Member
There was a problem hiding this comment.
Maybe a comment about why we have this on a timer?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
LauncherManager: listen to the changes in launchers in the configuration file
Closes: #39