LauncherManager: Fix crash when dnd a non desktop file #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
approved these changes
Oct 5, 2024
Contributor
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
Haven't tested but can reproduce and this makes sense for the fix
ryonakano
approved these changes
Oct 6, 2024
Member
ryonakano
left a comment
ryonakano
left a comment
There was a problem hiding this comment.
Confirmed the issue fixed but you can still drag & drop .desktop files from Applications Menu or Files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash that occured when trying to drag a non desktop file e.g. a normal textfile onto the dock.