Skip to content

Conversation

@lenemter
Copy link
Member

Supersedes #180
Fixes #275

@lenemter lenemter requested a review from a team October 31, 2024 14:34
@leolost2605
Copy link
Member

Screenshot from 2024-11-02 16 18 52@1x

The gap is the reason I opened #307

@teamcons
Copy link

teamcons commented Nov 5, 2024

Would it be possible to rework this one to take #307 into account, and still separate container ?
I would really appreciate separating container from window

@leolost2605
Copy link
Member

What do you mean by container separation? That it looks like the old dock or that it's just an additional widget?


child = overlay;

remove_css_class("background");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove_css_class ("background");

@teamcons
Copy link

teamcons commented Nov 5, 2024

What do you mean by container separation? That it looks like the old dock or that it's just an additional widget?

Not sure of the Vala aspect or if i understtood correctly so this may not be super articulate, but at the time, i cannot seem to specify in a CSS override a background that is smaller/does not englobe launchers - Such as the one Plank has by default.
It is fixed and cannot draw whatever - Because it also is the main window itself
some people will want the old plank style - and allowing to draw a background which isnt the one that has to contain everything, would allow third parties to offer it, and shift any critic like "i want it like this or that or whatever" to "ask the community lol"

@lenemter lenemter closed this Dec 3, 2024
@lenemter lenemter deleted the lenemter/separate-bg-from-window branch December 3, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cosmetic issue: app bounce clips app icon

6 participants