Skip to content

Add blur #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 14, 2025
Merged

Add blur #390

merged 3 commits into from
Sep 14, 2025

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Mar 6, 2025 •
edited
Loading

Requires elementary/gala#2293

To do:

  • How should we handle custom themes now??

@lenemter lenemter mentioned this pull request Mar 6, 2025
Closed
@lenemter lenemter changed the title Use Granite's Blur API Add blur Mar 6, 2025
@lenemter lenemter force-pushed the lenemter/blur-support branch from 2d041fc to 10581f7 Compare July 28, 2025 10:40
@lenemter lenemter requested a review from a team July 28, 2025 10:40
zeebok
zeebok approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@zeebok zeebok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Just have conflicts to resolve.

@lenemter lenemter force-pushed the lenemter/blur-support branch from 10581f7 to 24d4f43 Compare August 3, 2025 12:53
@danirabbit
Copy link
Member

danirabbit commented Aug 3, 2025

Gonna mark this as draft real quick so it doesn’t accidentally get merged before the gala API

@danirabbit danirabbit marked this pull request as draft August 3, 2025 20:48
@danirabbit danirabbit moved this to In progress in OS 8.1.0 Aug 7, 2025
@danirabbit danirabbit moved this from In progress to Blocked in OS 8.1.0 Aug 13, 2025
@teamcons
Copy link

teamcons commented Sep 4, 2025 

* [ ]  How should we handle custom themes now??

Not sure how it is affected by blur intro, but thats more upto community to figure out.
When it's there i will poke around to see what works or not and work around.

@lenemter lenemter force-pushed the lenemter/blur-support branch from ee734ce to 24d4f43 Compare September 14, 2025 07:28
@lenemter lenemter force-pushed the lenemter/blur-support branch from 24d4f43 to 7a6ef29 Compare September 14, 2025 07:28
@lenemter
Copy link
Member Author

lenemter commented Sep 14, 2025

I managed to avoid hardcoding bottom margin size so I guess it's good to go

@lenemter lenemter marked this pull request as ready for review September 14, 2025 08:22
@lenemter lenemter merged commit bf85936 into main Sep 14, 2025
4 checks passed
@lenemter lenemter deleted the lenemter/blur-support branch September 14, 2025 08:22
@github-project-automation github-project-automation bot moved this from Blocked to Done in OS 8.1.0 Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeebok zeebok zeebok approved these changes

Assignees

No one assigned

Labels

None yet

Projects

OS 8.1.0
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lenemter @danirabbit @teamcons @zeebok