Implement workspace reordering with drag and drop #392
Conversation
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
DynamicWorkspaceItem probably shouldn't support drag, dragging it does nothing as it can't be moved
|
Fixed |
src/BaseItem.vala
Outdated
| var drop_target = new Gtk.DropTarget (get_type (), MOVE) { | ||
| preload = true | ||
| }; | ||
| add_controller (drop_target); | ||
| drop_target.enter.connect (on_drop_enter); | ||
| drop_target.drop.connect (on_drop); |
There was a problem hiding this comment.
I think we still want to add drop target even when dran-and-drop isn't allowed
There was a problem hiding this comment.
Because dragging a workspace to the left of dynamic workspace icon doesn't do anything, while doing so on icon groups makes space for the dragged workspace
There was a problem hiding this comment.
Ah but just adding the drop target wont fix it since it only accepts drops from the same type
There was a problem hiding this comment.
Ok we support now a drag to the dynamic workspace icon.
|
There is a new visual glitch when dragging items: new.bug.mp4 |
|
Should be fixed now. Turns out the fancy calculation never actually did anything lol |
Fixes #381
Requires elementary/gala#2320
A few things: