Skip to content

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented May 14, 2025

Fixes #310 (Basecamp app)
Fixes #423
Fixes #428

Some windows run in portable mode (for example AppImages) and they do not provide any .desktop files by default. Right now Dock doesn't even show these windows. This branch constructs fake app info for them and always shows them.

I couldn't find a way to trick GLib.DesktopAppInfo into using fake data, so I created a wrapper for it.

Before

Screenshot from 2025-05-14 17 22 49

After

Screenshot from 2025-05-14 17 22 18

@lenemter lenemter added this to OS 9 May 14, 2025
@lenemter lenemter moved this to Needs Discussion in OS 9 May 14, 2025
@teamcons
Copy link

teamcons commented May 14, 2025

Reiterating the need for a fallback, to avoid people thinking (legitimately) the dock is broken
And to cover cases such as the above mentioned:
-Appimages
-Half baked APT apps
-Portable binaries
-When developing, testing prototypes

It could be a star or a grey question mark

@lenemter lenemter requested a review from a team May 14, 2025 15:03
@tintou
Copy link
Member

tintou commented May 15, 2025

Doesn't something like this work:

var keyfile = new GLib.KeyFile ();
keyfile.set_string (GLib.KeyFileDesktop.GROUP, GLib.KeyFileDesktop.KEY_TYPE, GLib.KeyFileDesktop.TYPE_APPLICATION);
var empty_appdata = new GLib.DesktopAppInfo.from_keyfile (keyfile);

@lenemter
Copy link
Member Author

@tintou You can't set fake id with this and using window title instead is too unreliable since 'Unknown window 1' can have 'Unknown window 2' as a modal dialog for example, but they'll be shown as separate icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Discussion

Development

Successfully merging this pull request may close these issues.

Dock not showing apps from wine, but the og plank showed Appimages are not showing up in the Dock Some apps are not showing up in the dock

6 participants