IconGroup: change focused style #439
Open
+55
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpkelso
approved these changes
Nov 10, 2025
Member
wpkelso
left a comment
wpkelso
left a comment
There was a problem hiding this comment.
I like this much better than the dot
leolost2605
requested changes
Nov 11, 2025
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
LGTM just a few code nits :)
Member
Author
|
@leolost2605 changed these are to handle on notify state instead of overwriting. That's way smarter! Thanks for the review :) |
leolost2605
requested changes
Nov 16, 2025
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
The dynamic workspace icon now doesn't get the focus style but apart from that looks great!
Member
Author
|
@leolost2605 do you mean the new workspace icon? I don't think that got a running indicator either. There should be no changes here to the logic of which thing gets an indicator, just styling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative idea for workspace focus styles so we're not conflating
runningwithfocusedFixes #399