Fix shaking of window when moving icon #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
requested changes
Aug 9, 2025
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
Can you please reverse the if statement here? Like this:
if (moving) {
return;
}
...
It usually makes the code more readable and removes unnecessary indentation.
Also, I think this needs a comment mentioning this fixes X11 bug
sebastianlay
force-pushed
the
fix-shaking
branch
from
28f7727 to
d60761d
Compare
Contributor
Author
|
Sounds good. I have inverted the condition and added a comment. Feel free to adjust the comment as I am not 100% sure what level of detail is expected or helpful. |
lenemter
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be caused by dragging the icon onto 'itself', which triggers the cycling through the open windows endlessly. This fix prevents the window cycle from starting while the icon is being moved around.
Fixes #432