Add shake to app icon when window cannot be opened #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
requested changes
Aug 9, 2025
sebastianlay
force-pushed
the
add-shake-on-denied-window
branch
from
189eb01 to
1fe5aeb
Compare
Contributor
Author
|
Sure thing. I have implemented the two suggestions and squashed the changes. |
sebastianlay
force-pushed
the
add-shake-on-denied-window
branch
from
1fe5aeb to
7abcdca
Compare
lenemter
requested changes
Aug 10, 2025
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
You also need to remove animation in cleanup method to avoid memory leak
sebastianlay
force-pushed
the
add-shake-on-denied-window
branch
from
7abcdca to
177f9b9
Compare
sebastianlay
force-pushed
the
add-shake-on-denied-window
branch
from
504fd5c to
d368132
Compare
Contributor
Author
|
Good point. I have added the animation to the |
danirabbit
approved these changes
Aug 14, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Looks good to me. Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a little shake to the launcher icon when a new window cannot be opened.
The code for the animation is mostly a copy of the animation in the PolkitDialog:
https://github.com/elementary/pantheon-agent-polkit/blob/main/src/PolkitDialog.vala#L287
Fixes #305