Skip to content

Small cleanup #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

Small cleanup #459

merged 2 commits into from
Sep 17, 2025

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Sep 17, 2025

Changes in ItemManager:

  • Add missing #if WORKSPACE_SWITCHER for separator
  • Use settings.changed["icon-size"]instead of manually checking the key

Changes in MainWindow:

  • Container doesn't use Gtk.Box, so make it subclass Gtk.Widget instead
  • Avoid retrieving surface in signal handlers, the surface is already passed into handlers automatically

@lenemter lenemter requested a review from a team September 17, 2025 19:40
@lenemter lenemter mentioned this pull request Sep 17, 2025
Merged
danirabbit
danirabbit approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice little improvements

@danirabbit danirabbit merged commit 9fa93cb into main Sep 17, 2025
4 checks passed
@danirabbit danirabbit deleted the lenemter/cleanup branch September 17, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lenemter @danirabbit