Launcher: better badge animation #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
reviewed
Sep 20, 2025
| // Avoid a stutter at the beginning | ||
| badge.opacity = 0; | ||
|
|
||
| if (app.count_visible && (notify_settings == null || !notify_settings.get_boolean ("do-not-disturb"))) { |
Contributor
There was a problem hiding this comment.
What is the idea behind the DND check here? It looks like it skips this and will use the default up above and still animate. And then if it is removing the badge and DND is on, it will use the default but won't be reversed. Am I reading this right?
Member
Author
There was a problem hiding this comment.
I kept this the same as it was before. I think it's if the badge should be visible AND (either do not disturb status is unknown OR do not disturb is off) → Do all the badge show animations otherwise do all the badge hide animations.
In other words, if do not disturb is turned on, don't show badges. We only need to check if DnD is turned on to show badges, we don't need to check it to hide badges
zeebok
approved these changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #465
Kooha-2025-09-18-11-23-39.mp4