BaseIconGroup: Use FlowBox instead of manual layouting #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
reviewed
Nov 3, 2025
danirabbit
requested changes
Nov 3, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
I'm in favor of this, but it does look like for single items that they aren't center aligned
Member
|
Another small problem here, the icons are swallowing clicks for the item |
Member
Author
|
@danirabbit should both be fixed now :) |
danirabbit
approved these changes
Nov 10, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Hell yeah. This looks great and we love to save some lines. Nice work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less complicated logic.
This brings a little change in behavior that I came across while experimenting and that I quite liked that is that we keep the icons centered even if we have only one or two: (Ignore the high opacity, there seems to be something broken when screenshotting a window with blur behind, in reality it looks like the old version)
But it's trivial to change it to the old behavior so lmk what you think :)