Skip to content

Conversation

@meisenzahl
Copy link
Member

@meisenzahl meisenzahl requested a review from a team February 3, 2022 15:46
Copy link
Member

@JoseExposito JoseExposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! One question: since the sound is being played on the workspace manager, wouldn't it be played if Gala crashes and is relaunched?

@meisenzahl
Copy link
Member Author

@JoseExposito yes if Gala would crash, the sound would be played again.

Do you have any idea how to prevent this?

@JoseExposito
Copy link
Member

Maybe you could use org.gnome.SessionManager to handle this case? I'm not sure if there is a signal/method you can use there. Gala already has a SessionManager class, so part of the job should be already done.

@JoseExposito
Copy link
Member

Code looks good, thanks!!! Handing over to the @elementary/ux team for their input.

Personal opinion: I'm am not a big fan of login sounds, so I'll be happy if this was something configurable in settings.

@cassidyjames
Copy link
Contributor

Yeah, I don't think a login sound is desirable by default. I could see the argument for a "ready" sound from an accessibility standpoint, but then it would need to be short and subtle enough to not be annoying every time you turn on your computer. We would also likely want a similar sound on the login screen to signal that's available for typing a password. Regardless, I think that would be off by default?

@meisenzahl
Copy link
Member Author

@elementary/ux is there any interest in adding optional system sounds?

@SubhadeepJasu
Copy link

Regarding the exact sounds, just posting them from here:
elementary/sound-theme#16
elementary/triage#98
Let me know if these are okay.

@vjr
Copy link
Member

vjr commented Nov 28, 2024

My opinion is to play this in (perhaps) the greeter and not gala - so its a startup sound and not login - what say?

@SubhadeepJasu
Copy link

SubhadeepJasu commented Dec 22, 2024

My opinion is to play this in (perhaps) the greeter and not gala - so its a startup sound and not login - what say?

I like that. I also made a sound for shutdown. Can that be integrated in?

@lenemter lenemter added the Conflicts Has conflicts with the target branch label Jan 18, 2025
@lenemter lenemter added this to OS 9 Jul 31, 2025
@lenemter lenemter moved this to Needs Discussion in OS 9 Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Conflicts Has conflicts with the target branch

Projects

Status: Needs Discussion

Development

Successfully merging this pull request may close these issues.

7 participants