Skip to content

IconGroupContainer/force_reposition: Fix crash (use after free) #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

IconGroupContainer/force_reposition: Fix crash (use after free) #1990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Widgets/IconGroupContainer.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,15 @@ namespace Gala {

foreach (var child in children) {
if (child is IconGroup) {
child.ref (); //The list only contains weak references so make sure the child isn't freed before it's added again
remove_group ((IconGroup) child);
}
}

foreach (var child in children) {
if (child is IconGroup) {
add_group ((IconGroup) child);
child.unref ();
}
}
}
Expand Down