Skip to content

PanelClone: avoid using Timeout #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 26, 2024
Merged

PanelClone: avoid using Timeout #2015

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e7961ee
PanelClone: avoid using Timeout
lenemter Aug 10, 2024
d8870db
Check if transition is null
lenemter Aug 12, 2024
7e21699
Merge branch 'main' into lenemter/use-transition
lenemter Aug 12, 2024
d3db9bf
Merge branch 'main' into lenemter/use-transition
zeebok Aug 23, 2024
119fb14
Merge branch 'main' into lenemter/use-transition
leolost2605 Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/ShellClients/PanelClone.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,18 +136,15 @@ public class Gala.PanelClone : Object {
return;
}

var animation_duration = get_animation_duration ();

clone.save_easing_state ();
clone.set_easing_mode (Clutter.AnimationMode.EASE_OUT_QUAD);
clone.set_easing_duration (animation_duration);
clone.set_easing_duration (get_animation_duration ());
clone.y = calculate_clone_y (false);
clone.restore_easing_state ();

Timeout.add (animation_duration, () => {
clone.get_transition ("y").completed.connect (() => {
clone.visible = false;
panel_hidden = false;
return Source.REMOVE;
});
}
}