Skip to content

Fix autohide #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Fix autohide #2086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8bc1b8b
Fix autohide
lenemter Oct 13, 2024
feac9af
Update src/ShellClients/HideTracker.vala
danirabbit Oct 15, 2024
1891276
Update HideTracker.vala
danirabbit Oct 15, 2024
3ea82c2
Merge branch 'main' into lenemter/fix-dock
danirabbit Oct 15, 2024
de408b1
Merge branch 'main' into lenemter/fix-dock
danirabbit Oct 15, 2024
cf9680a
Update gala.metainfo.xml.in
danirabbit Oct 15, 2024
021581a
Merge branch 'main' into lenemter/fix-dock
leolost2605 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions data/gala.metainfo.xml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
<issue url="https://github.com/elementary/gala/issues/1898">wayland: opening windows when overview is opened breaks a lot</issue>
<issue url="https://github.com/elementary/gala/issues/2053">Window renders black</issue>
<issue url="https://github.com/elementary/gala/issues/2067">Terminal and System Settings have generic icon in multitasking view on Wayland</issue>
<issue url="https://github.com/elementary/gala/issues/2083">Autohide is too sensitive</issue>
<issue url="https://github.com/elementary/dock/issues/78">Touch support - getting the dock to display when hidden</issue>
</issues>
</release>
Expand Down
7 changes: 5 additions & 2 deletions src/ShellClients/HideTracker.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,13 @@ public class Gala.HideTracker : Object {
}

private void toggle_display (bool should_hide) {
unowned var window_actor = (Meta.WindowActor) panel.window.get_compositor_private ();

// Window actor receives pointer events while hidden on X11: https://github.com/elementary/gala/issues/2083
#if HAS_MUTTER45
hovered = panel.window.has_pointer ();
hovered = panel.window.has_pointer () && window_actor.visible;
#else
hovered = window_has_pointer ();
hovered = window_has_pointer () && window_actor.visible;
#endif

if (should_hide && !hovered && !panel.window.has_focus ()) {
Expand Down