Skip to content

Fix panel sometimes being behind windows #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Fix panel sometimes being behind windows #2094

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff031bc
Fix panel sometimes being behind windows
leolost2605 Oct 16, 2024
bf6d39c
Merge branch 'main' into leolost/fix-panel-flicker
zeebok Oct 22, 2024
9dfd3ef
Fix wingpanel issue
leolost2605 Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/ShellClients/PanelClone.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ public class Gala.PanelClone : Object {
}
});

// Make sure the actor is visible once it's focused FIXME: better event not only focused
// https://github.com/elementary/gala/issues/2080
panel.window.focused.connect (update_visible);

update_visible ();
update_clone_position ();

Expand All @@ -77,6 +81,12 @@ public class Gala.PanelClone : Object {

private void update_visible () {
actor.visible = !panel_hidden;

if (actor.visible && !wm.get_display ().get_monitor_in_fullscreen (panel.window.get_monitor ())) {
// The actor has just been revealed, make sure it's at the top
// https://github.com/elementary/gala/issues/2080
actor.get_parent ().set_child_above_sibling (actor, null);
}
}

private void update_clone_position () {
Expand Down