Skip to content

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Dec 3, 2024

Fixes #1967
Fixes #2113
Fixes #2131

@lenemter lenemter requested review from a team and vjr December 3, 2024 21:05
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor comments apart from that makes sense to me but I don't really know the inner workings here :)

Copy link
Member

@vjr vjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm it fixes at least #1967 for me!

@vjr vjr mentioned this pull request Dec 4, 2024
@vjr vjr self-requested a review December 4, 2024 02:37
@vjr
Copy link
Member

vjr commented Dec 4, 2024

@lenemter just wondering whether instead of doing this in code is it not possible/advisable to configure this systemd service/unit to start via the config files?

@lenemter
Copy link
Member Author

lenemter commented Dec 4, 2024

@vjr gnome shell does it this way, I think they know how to do this better than me :)

@lenemter lenemter requested a review from leolost2605 December 4, 2024 10:06
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM :)

@lenemter lenemter merged commit 24b05bb into main Dec 4, 2024
5 checks passed
@lenemter lenemter deleted the lenemter/fix-xsettings branch December 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Recently fixed

4 participants