Move window to old workspace when destroying the window

[lenemter]

Fixes #1986

[leolost2605]

Unfortunately this crashes for me when closing a fullscreen window

#0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:44
#1  __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78
#2  __GI___pthread_kill (threadid=<optimized out>, signo=signo@entry=6) at ./nptl/pthread_kill.c:89
#3  0x0000725dec84526e in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#4  0x0000725dec8288ff in __GI_abort () at ./stdlib/abort.c:79
#5  0x0000725dee1d1f5b in g_assertion_message
    (domain=domain@entry=0x725ded1b5014 "libmutter", file=file@entry=0x725ded1bdbcf "../src/core/workspace.c", line=line@entry=294, func=func@entry=0x725ded1e7000 <__func__.11.lto_priv.6> "assert_workspace_empty", message=message@entry=0x5784deb5a080 "assertion failed: (window->on_all_workspaces)") at ../../../glib/gtestutils.c:3331
#6  0x0000725dee23aa97 in g_assertion_message_expr
    (domain=domain@entry=0x725ded1b5014 "libmutter", file=file@entry=0x725ded1bdbcf "../src/core/workspace.c", line=line@entry=294, func=func@entry=0x725ded1e7000 <__func__.11.lto_priv.6> "assert_workspace_empty", expr=expr@entry=0x725ded1bdc7e "window->on_all_workspaces") at ../../../glib/gtestutils.c:3357
#7  0x0000725ded0ef360 in assert_workspace_empty (workspace=<optimized out>) at ../src/core/workspace.c:294
#8  assert_workspace_empty (workspace=0x5784deb62010) at ../src/core/workspace.c:288
#9  meta_workspace_relocate_windows (workspace=0x5784deb62010, new_home=0x5784ddd9e370) at ../src/core/workspace.c:439
#10 0x0000725ded0dbcbf in meta_workspace_manager_remove_workspace (workspace_manager=0x5784ddd9df20, workspace=0x5784deb62010, timestamp=0)
    at ../src/core/meta-workspace-manager.c:317
#11 0x00005784dc249a5b in gala_workspace_manager_remove_workspace (self=0x5784dde18c30, workspace=0x5784deb62010) at ../src/WorkspaceManager.vala:235
#12 0x00005784dc248ba2 in gala_workspace_manager_workspace_switched (self=0x5784dde18c30, manager=0x5784ddd9df20, from=1, to=0, direction=META_MOTION_LEFT)
    at ../src/WorkspaceManager.vala:116
#13 0x00005784dc2483e1 in _gala_workspace_manager_workspace_switched_meta_workspace_manager_workspace_switched
    (_sender=0x5784ddd9df20, object=1, p0=0, p1=META_MOTION_LEFT, self=0x5784dde18c30) at ../src/WorkspaceManager.vala:73
#14 0x0000725dec7fbb16 in ??? () at /lib/x86_64-linux-gnu/libffi.so.8
#15 0x0000725dec7f83ef in ??? () at /lib/x86_64-linux-gnu/libffi.so.8
#16 0x0000725dec7fb0be in ffi_call () at /lib/x86_64-linux-gnu/libffi.so.8
#17 0x0000725dee16adb2 in g_cclosure_marshal_generic
    (closure=<optimized out>, return_gvalue=<optimized out>, n_param_values=<optimized out>, param_values=<optimized out>, invocation_hint=<optimized out>, marshal_data=<optimized out>) at ../../../gobject/gclosure.c:1538
#18 0x0000725dee1642fa in g_closure_invoke (closure=0x5784ddd1e600, return_value=0x0, n_param_values=4, param_values=0x7ffcb7471340, invocation_hint=0x7ffcb7471290)
    at ../../../gobject/gclosure.c:834
#19 0x0000725dee193c79 in signal_emit_unlocked_R.isra.0
    (node=node@entry=0x7ffcb7471460, detail=detail@entry=0, instance=instance@entry=0x5784ddd9df20, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffcb7471340) at ../../../gobject/gsignal.c:3961
#20 0x0000725dee184591 in signal_emit_valist_unlocked
    (instance=instance@entry=0x5784ddd9df20, signal_id=signal_id@entry=216, detail=detail@entry=0, var_args=var_args@entry=0x7ffcb74715d0) at ../../../gobject/gsignal.c:3520
#21 0x0000725dee1847c1 in g_signal_emit_valist (instance=0x5784ddd9df20, signal_id=216, detail=0, var_args=var_args@entry=0x7ffcb74715d0) at ../../../gobject/gsignal.c:3263
--Type <RET> for more, q to quit, c to continue without paging--c
#22 0x0000725dee184883 in g_signal_emit (instance=<optimized out>, signal_id=<optimized out>, detail=detail@entry=0) at ../../../gobject/gsignal.c:3583
#23 0x0000725ded0efb23 in meta_workspace_manager_workspace_switched (direction=META_MOTION_LEFT, to=0, from=1, workspace_manager=<optimized out>)
    at ../src/core/meta-workspace-manager.c:1025
#24 meta_workspace_activate_with_focus (workspace=0x5784ddd9e370, focus_this=<optimized out>, timestamp=0) at ../src/core/workspace.c:690
#25 0x00005784dc23ad4f in gala_window_manager_gala_move_window_to_old_ws (self=0x5784ddda0110, window=0x5784deb565a0) at ../src/WindowManager.vala:1818
#26 0x00005784dc239264 in gala_window_manager_gala_real_destroy (base=0x5784ddda0110, actor=0x5784deb7c750) at ../src/WindowManager.vala:1581
#27 0x0000725ded0bc1d7 in meta_plugin_manager_event_simple (event=<optimized out>, actor=0x5784deb7c750, plugin_mgr=0x5784ddda14c0)
    at ../src/compositor/meta-plugin-manager.c:230
#28 start_simple_effect (self=0x5784deb7c750, event=<optimized out>) at ../src/compositor/meta-window-actor.c:797
#29 0x0000725ded0af821 in meta_window_actor_hide (effect=META_COMP_EFFECT_DESTROY, self=0x5784deb7c750) at ../src/compositor/meta-window-actor.c:1079
#30 meta_window_actor_hide (effect=META_COMP_EFFECT_DESTROY, self=0x5784deb7c750) at ../src/compositor/meta-window-actor.c:1045
#31 meta_compositor_hide_window (compositor=<optimized out>, window=<optimized out>, effect=META_COMP_EFFECT_DESTROY) at ../src/compositor/compositor.c:540
#32 0x0000725ded0e7771 in meta_window_unmanage (window=0x5784deb565a0, timestamp=<optimized out>) at ../src/core/window.c:1432
#33 0x0000725ded15eaf8 in meta_wayland_shell_surface_destroy_window (shell_surface=<optimized out>) at ../src/wayland/meta-wayland-shell-surface.c:312
#34 0x0000725ded165e5d in xdg_toplevel_destructor (resource=<optimized out>) at ../src/wayland/meta-wayland-xdg-shell.c:220
#35 0x0000725dede4b2b1 in ??? () at /lib/x86_64-linux-gnu/libwayland-server.so.0
#36 0x0000725dede4d22a in wl_resource_destroy () at /lib/x86_64-linux-gnu/libwayland-server.so.0
#37 0x0000725dec7fbb16 in ??? () at /lib/x86_64-linux-gnu/libffi.so.8
#38 0x0000725dec7f83ef in ??? () at /lib/x86_64-linux-gnu/libffi.so.8
#39 0x0000725dec7fb0be in ffi_call () at /lib/x86_64-linux-gnu/libffi.so.8
#40 0x0000725dede48393 in ??? () at /lib/x86_64-linux-gnu/libwayland-server.so.0
#41 0x0000725dede4cbb4 in ??? () at /lib/x86_64-linux-gnu/libwayland-server.so.0
#42 0x0000725dede4b402 in wl_event_loop_dispatch () at /lib/x86_64-linux-gnu/libwayland-server.so.0
#43 0x0000725ded14435b in wayland_event_source_dispatch (base=base@entry=0x5784ddd7dde0, callback=<optimized out>, data=<optimized out>) at ../src/wayland/meta-wayland.c:139
#44 0x0000725dee20f5b5 in g_main_dispatch (context=0x5784dd87bff0) at ../../../glib/gmain.c:3344
#45 0x0000725dee26e717 in g_main_context_dispatch_unlocked (context=0x5784dd87bff0) at ../../../glib/gmain.c:4152
#46 g_main_context_iterate_unlocked.isra.0 (context=0x5784dd87bff0, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../../../glib/gmain.c:4217
#47 0x0000725dee20ff77 in g_main_loop_run (loop=0x5784dde27d00) at ../../../glib/gmain.c:4419
#48 0x0000725ded0d50fa in meta_context_run_main_loop (context=<optimized out>, error=0x7ffcb74723a0) at ../src/core/meta-context.c:523
#49 0x00005784dc2100c9 in gala_main (args=0x7ffcb74729f8, args_length1=1) at ../src/Main.vala:88
#50 0x00005784dc2102b4 in main (argc=1, argv=0x7ffcb74729f8) at ../src/Main.vala:29