Skip to content

WindowManager: Only show notifications after their window was shown #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 21, 2024
Merged

WindowManager: Only show notifications after their window was shown #2183

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bad84a6
WindowManager: Only show notifications after their window was shown
lenemter Dec 19, 2024
3c58930
Fix lint
lenemter Dec 19, 2024
4e15658
.
lenemter Dec 20, 2024
a0bfda8
Merge branch 'main' into lenemter/fix-notifications-crash
lenemter Dec 21, 2024
26486f9
Remove Source.CONTINUE
lenemter Dec 21, 2024
04583c5
Merge branch 'main' into lenemter/fix-notifications-crash
leolost2605 Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/InternalUtils.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,5 +355,17 @@ namespace Gala {
return Source.REMOVE;
});
}

public static void wait_for_window_actor_to_show (Meta.Window window, owned WindowActorReadyCallback callback) {
unowned var window_actor = (Meta.WindowActor) window.get_compositor_private ();
if (window_actor.visible) {
callback (window_actor);
return;
}

InternalUtils.wait_for_window_actor (window, (actor) => {
actor.show.connect (() => callback (actor));
});
}
}
}
7 changes: 4 additions & 3 deletions src/WindowManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2120,9 +2120,10 @@ namespace Gala {
// TODO: currently only notifications are handled here, other windows should be too
switch_workspace_window_created_id = window_created.connect ((window) => {
if (NotificationStack.is_notification (window)) {
unowned var actor = (Meta.WindowActor) window.get_compositor_private ();
clutter_actor_reparent (actor, notification_group);
notification_stack.show_notification (actor);
InternalUtils.wait_for_window_actor_to_show (window, (actor) => {
clutter_actor_reparent (actor, notification_group);
notification_stack.show_notification (actor);
});
}
});

Expand Down
Loading