Skip to content

HideTracker: Disconnect timeouts on unmanaging #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2025
Merged

HideTracker: Disconnect timeouts on unmanaging #2272

merged 1 commit into from
Feb 15, 2025
+15 −10

Conversation

@leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Feb 15, 2025

Fixes #2267

Explanation from the code comment:

The timeouts hold refs on us so we stay connected to signal handlers that might
access the panel which was already freed. To prevent that make sure we reset
the timeouts so that we get freed immediately

@leolost2605 leolost2605 requested a review from a team February 15, 2025 15:37
lenemter
lenemter approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the crash. Good job!

@lenemter lenemter merged commit 7ace625 into main Feb 15, 2025
5 checks passed
@lenemter lenemter deleted the leolost/hidetracker-disconnect-timeouts branch February 15, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenemter lenemter lenemter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dock crash may crash Gala

3 participants

@leolost2605 @lenemter