Skip to content

Shorten long keybinding lines #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lenemter
Copy link
Member

From vala-lint:
148 warnings in main -> 135 warnings

@lenemter lenemter requested a review from a team March 13, 2025 13:31
@leolost2605
Copy link
Member

I think the vapi is actually outdated here. It seems like since https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4080 it should be more like

public delegate void KeyHandlerFunc (Meta.Display display, Meta.Window? window, Clutter.Event event, Meta.KeyBinding binding);

and then we can also drop the additional metadata for the event type I think?
ping @tintou since he's done most of the vapi stuff :)

@lenemter
Copy link
Member Author

@leolost2605 Won't this KeyHandlerFunc signature only be available in mutter 48?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants