Shorten long keybinding lines #2310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think the vapi is actually outdated here. It seems like since https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4080 it should be more like and then we can also drop the additional metadata for the event type I think? |
Member
Author
|
@leolost2605 Won't this KeyHandlerFunc signature only be available in mutter 48? |
zeebok
approved these changes
Jun 2, 2025
Contributor
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
Assuming the VAPI isn't out of date this seems good
Collaborator
|
@lenemter Can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From vala-lint:
148 warnings in main -> 135 warnings