Skip to content

Multitasking view fixes #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2025
Merged

Multitasking view fixes #2319

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cd8f3b
MultitaskingView: Only show and push modal if it's not already shown
leolost2605 Mar 16, 2025
3f555db
MultitaskingView: Stop events from propagating while closed
leolost2605 Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/Widgets/MultitaskingView/MultitaskingView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ namespace Gala {
}

public override void start_progress (GestureAction action) {
if (!opened) {
if (!visible) {
opened = true;

wm.background_group.hide ();
Expand Down Expand Up @@ -508,5 +508,19 @@ namespace Gala {

return true;
}

public override bool captured_event (Clutter.Event event) {
/* If we aren't open but receive events this means we are animating closed
* or we are finishing a workspace switch animation. In any case we want to
* prevent a drag and drop to start for the window clones which can happen
* pretty easily if you click on one while the animation finishes.
*/
var type = event.get_type (); // LEAVE and ENTER have to be propagated
if (!opened && animating && type != ENTER && type != LEAVE) {
return Clutter.EVENT_STOP;
}

return Clutter.EVENT_PROPAGATE;
}
}
}