Introduce ScreenShield #2343
Open
Introduce ScreenShield #2343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
force-pushed
the
lenemter/introduce-screen-shield
branch
4 times, most recently
from
e5666ea to
17ef785
Compare
leolost2605
requested changes
Apr 5, 2025
| public int64 activation_time { get; private set; default = 0; } | ||
| if (_active != value) { | ||
| _active = value; | ||
| notify_property ("active"); |
There was a problem hiding this comment.
IIRC you don't actually have to notify manually (we don't do explicit notify https://docs.gtk.org/gobject/signal.Object.notify.html)
| return Clutter.EVENT_STOP; | ||
| } | ||
|
|
||
| public override bool motion_event (Clutter.Event event) { |
There was a problem hiding this comment.
Can we collect all events at once in event (Clutter.Event event) and filter them by type instead of having three handlers doing the same thing?
| } | ||
|
|
||
| public void deactivate () { | ||
| if (!active) { |
There was a problem hiding this comment.
IIUC we only set active to true once the animation completes so could this lead to us trying to deactivate while animating which would be ignored? And if so is that wanted?
| return; | ||
| } | ||
|
|
||
| add_constraint (new Clutter.BindConstraint (parent, Clutter.BindCoordinate.SIZE, 0.0f)); |
There was a problem hiding this comment.
That's cool I didn't know this existed :)
lenemter
force-pushed
the
lenemter/introduce-screen-shield
branch
from
17ef785 to
ad11cc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the actor and all the animations from SessionLocker into a separate class that can later be used for #1999 and #836