Streamline monitor scale passing #2354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Same name monitor_scale everywhere to show it belongs together - Use property bindings to update scales of children - Make monitor_scale always construct set - Therefore use notify instead of setters for reallocation - The last two points are to avoid duplicate allocations on construction
lenemter
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently e.g. in window clone we call
reallocatetwice when constructing:Same in workspace clone.
Sidenote: I plan to make closebutton and windowicon scale settable which is why I already require construct set and use notify in the windowclone even though we could currently make monitor scale there only set and call reallocate in its setter.