Remodel GestureController lifetimes #2355
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are leaking WindowClones since #2327. This is because the GestureController holds a strong reference on the target which means in our case that the windowclone holds a strong ref on the controller which holds a strong ref on the window clone => ref cycle. That is for example also why we set it to null in the panelwindow once it unmanages
gala/src/ShellClients/PanelWindow.vala
Line 54 in a986881
While we could easily work around this I admit for how we currently use it the ownership model of gesturecontrollers is not really intuitive.
There are multiple solutions to this problem:
I went with the last one because IMO it's the least error prone and thus safest :)
Also don't hold a ref on the actor in the ScrollBackend because it's unneeded and would cause another ref cycle.