Skip to content

Remove destroy effect for menus #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025
Merged

Remove destroy effect for menus #2371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
900e946
Remove destroy effect for menus
lenemter May 8, 2025
3ad2be1
Update metainfo
lenemter May 8, 2025
2b20cf8
Merge branch 'main' into lenemter/remove-desrtoy-effect-for-menus
lenemter May 8, 2025
53c9aa4
Merge branch 'main' into lenemter/remove-desrtoy-effect-for-menus
danirabbit May 8, 2025
f48e244
Merge branch 'main' into lenemter/remove-desrtoy-effect-for-menus
danirabbit May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions data/gala.metainfo.xml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,14 @@
<issue url="https://github.com/elementary/gala/issues/1235">Overview window title should follow keyboard focus</issue>
<issue url="https://github.com/elementary/gala/issues/1661">Better post-screenshot animation</issue>
<issue url="https://github.com/elementary/gala/issues/2114">Wrong context menu placement</issue>
<issue url="https://github.com/elementary/gala/issues/2172">Override redirect Popup menu type window under Xwayland can not be displayed on the second XMapWindow</issue>
<issue url="https://github.com/elementary/gala/issues/2199">Swiping in the multitasking view can close applications</issue>
<issue url="https://github.com/elementary/gala/issues/2260">Ghost of window on another workspace appears when cancelling workspace swipe</issue>
<issue url="https://github.com/elementary/gala/issues/2267">Dock crash may crash Gala</issue>
<issue url="https://github.com/elementary/gala/issues/2279">Can't reveal dock when animations are disabled</issue>
<issue url="https://github.com/elementary/gala/issues/2294">Unlocking firewall settings leads to crash</issue>
<issue url="https://github.com/elementary/gala/issues/2341">Lutris Flatpak crashes gala with GE setup</issue>
<issue url="https://github.com/elementary/gala/issues/2366">Menus only show once</issue>
<issue url="https://github.com/elementary/portals/issues/97">False detection of "background activity" for some Flatpak apps</issue>
</issues>
</release>
Expand Down
25 changes: 0 additions & 25 deletions src/WindowManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1471,31 +1471,6 @@ namespace Gala {
actor.opacity = 0U;
actor.restore_easing_state ();

ulong destroy_handler_id = 0UL;
destroy_handler_id = actor.transitions_completed.connect (() => {
actor.disconnect (destroy_handler_id);
destroying.remove (actor);
destroy_completed (actor);
});

break;
case Meta.WindowType.MENU:
case Meta.WindowType.DROPDOWN_MENU:
case Meta.WindowType.POPUP_MENU:
var duration = AnimationDuration.MENU_MAP;
if (duration == 0) {
destroy_completed (actor);
return;
}

destroying.add (actor);
actor.save_easing_state ();
actor.set_easing_mode (Clutter.AnimationMode.EASE_OUT_QUAD);
actor.set_easing_duration (duration);
actor.set_scale (0.8f, 0.8f);
actor.opacity = 0U;
actor.restore_easing_state ();

ulong destroy_handler_id = 0UL;
destroy_handler_id = actor.transitions_completed.connect (() => {
actor.disconnect (destroy_handler_id);
Expand Down
Loading