KeyboardManager: cleanup #2372
Merged
KeyboardManager: cleanup #2372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lenemter
commented
May 8, 2025
lenemter
commented
- Don't make KeyboardManager object static
- Don't check for gsettings schema
- Move 'switch-input-source' keybindings here
lenemter
force-pushed
the
lenemter/cleanup-keyboard-manager
branch
from
ce60f85 to
b55b688
Compare
lenemter
force-pushed
the
lenemter/cleanup-keyboard-manager
branch
from
b55b688 to
553e2dd
Compare
danirabbit
approved these changes
May 8, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Makes sense and looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.