Skip to content

DesktopIntegration: Don't resend windows when switching workspace #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2025
Merged

DesktopIntegration: Don't resend windows when switching workspace #2374

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4edb9de
DesktopIntegration: Don't resend windows when switching workspace
lenemter May 8, 2025
8e90b6e
Merge branch 'main' into lenemter/optimize-active-workspace
lenemter May 8, 2025
76479c4
Merge branch 'main' into lenemter/optimize-active-workspace
zeebok Jun 5, 2025
53a27d7
Merge branch 'main' into lenemter/optimize-active-workspace
leonardo-lemos Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/DesktopIntegration.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ public class Gala.DesktopIntegration : GLib.Object {
unowned var display = wm.get_display ();
unowned var workspace_manager = display.get_workspace_manager ();

workspace_manager.active_workspace_changed.connect (() => {
active_workspace_changed ();
windows_changed (); // windows have 'on-active-workspace' property that we need to update
});
workspace_manager.active_workspace_changed.connect (() => active_workspace_changed ());
workspace_manager.workspaces_reordered.connect (() => windows_changed ());
workspace_manager.workspace_added.connect (() => windows_changed ());
workspace_manager.workspace_removed.connect ((index) => {
Expand Down Expand Up @@ -99,7 +96,6 @@ public class Gala.DesktopIntegration : GLib.Object {
public Window[] get_windows () throws GLib.DBusError, GLib.IOError {
Window[] returned_windows = {};
var apps = Gala.AppSystem.get_default ().get_running_apps ();
unowned var active_workspace = wm.get_display ().get_workspace_manager ().get_active_workspace ();
foreach (unowned var app in apps) {
foreach (weak Meta.Window window in app.get_windows ()) {
if (!is_eligible_window (window)) {
Expand All @@ -116,7 +112,6 @@ public class Gala.DesktopIntegration : GLib.Object {
properties.insert ("client-type", new GLib.Variant.uint32 (window.get_client_type ()));
properties.insert ("is-hidden", new GLib.Variant.boolean (window.is_hidden ()));
properties.insert ("has-focus", new GLib.Variant.boolean (window.has_focus ()));
properties.insert ("on-active-workspace", new GLib.Variant.boolean (window.located_on_workspace (active_workspace)));
properties.insert ("workspace-index", new GLib.Variant.int32 (window.get_workspace ().index ()));
properties.insert ("width", new GLib.Variant.uint32 (frame_rect.width));
properties.insert ("height", new GLib.Variant.uint32 (frame_rect.height));
Expand Down