GestureController: Handle gesture interruption transparently #2411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2409
Once one finger gets lifted we switch from touch egg backend to scroll backend which would emit end and start signals which would cause a hide and show on the multitasking view which in turn would interrupt and restart the scroll gesture but not emit a end because of a wrong order. We can solve all these problems if we just don't emit start and end when the gesture gets interrupted while still going. This also is a small performance improvement because we don't go hidden shown everytime which saves us a bunch of recalculations.
Also don't allow a new gesture to start while one is already going.
(thanks @zeebok for the reproducer)