Release the Barrier once the threshhold is reached #2425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
approved these changes
Jun 2, 2025
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
Code looks good. But I can't test it since I don't have a second monitor
leonardo-lemos
requested changes
Jun 3, 2025
Collaborator
leonardo-lemos
left a comment
leonardo-lemos
left a comment
There was a problem hiding this comment.
It works, but I think it could be improved. The cursor transition between monitors doesn't feel smooth — it gets stuck between them for too long. Maybe reducing the delay time would help.
leonardo-lemos
approved these changes
Jun 9, 2025
Collaborator
leonardo-lemos
left a comment
leonardo-lemos
left a comment
There was a problem hiding this comment.
Nice! 150 works very well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to release the barrier once it was triggered for a certain amount of time to allow the cursor to travel to a new monitor. We can play with the amount of time a bit but 200 seemed ok to me 🤷
Fixes #2424
Fixes elementary/dock#68