WindowClone: display modal dialogs on top of parent window #2522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
pushed a commit
that referenced
this pull request
Oct 13, 2025
Closes #2353 Introduce a window list model that allows us to collect the filtering and sorting code for different views of the current window list in a single place Since this window list model now also guarantees that all windows that appear in it have a valid actor i.e. get_compositor_private won't return null this will allow for a bunch of clean up in a follow up :) This should also help quite a bit with #2522 to allow more deduplication there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #198
The first commit is a cleanup. Moves handling
InternalUtils.wait_for_window_actor_visiblefrom the WindowClone into the WindowCloneContainer since it reduces complexity of WindowClone class. Also moves the filtering of the windows into WindowCloneContainer, including checking for duplicate windows.Before
After