Support keyboard navigation over multiple monitors in multitasking view #2536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually handling keyboard focus where needed, do it like GTK does it with some adaptations.
We have the FocusController which exists only once for a stage. This handles receiving keyboard events and moving focus according to them.
Then we have the focusable interface which is implemented by the actors in the actor tree where focus is needed. The interface handles deciding which implementor gets the focus based on the direction.
To hook controller and focusable up we can register the top most focusable in a certain area (in this case the multitasking view) as a root focusable. There may only be one mapped root focusable at a time and it will receive the focus calls from the controller based on key presses.
We now also hide the focus indicator after 5 seconds.