Skip to content

Handle visible_in_multitasking_view in PanelWindow #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2025
Merged

Handle visible_in_multitasking_view in PanelWindow #2563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
278cf51
Handle visible in multitasking view in PanelWindow
leolost2605 Oct 10, 2025
34ff0f5
Merge branch 'main' into leolost/visisble-in-mtv-in-panel
leolost2605 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/ShellClients/PanelWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ public class Gala.PanelWindow : ShellWindow, RootTarget {
}
}

public bool visible_in_multitasking_view { get; private set; default = false; }

private GestureController gesture_controller;
private HideTracker hide_tracker;

Expand Down Expand Up @@ -64,6 +66,14 @@ public class Gala.PanelWindow : ShellWindow, RootTarget {
actor.add_action (new DragDropAction (DESTINATION, "multitaskingview-window"));
}

protected override double get_hidden_progress () {
if (visible_in_multitasking_view) {
return double.min (gesture_controller.progress, 1 - base.get_hidden_progress ());
} else {
return double.max (gesture_controller.progress, base.get_hidden_progress ());
}
}

private void hide () {
gesture_controller.goto (1);
}
Expand Down
38 changes: 7 additions & 31 deletions src/ShellClients/ShellWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,9 @@
public class Gala.ShellWindow : PositionedWindow, GestureTarget {
public Clutter.Actor? actor { get { return window_actor; } }
public bool restore_previous_x11_region { private get; set; default = false; }
public bool visible_in_multitasking_view { get; set; default = false; }

private Meta.WindowActor window_actor;
private double custom_progress = 0;
private double multitasking_view_progress = 0;

private int animations_ongoing = 0;

private PropertyTarget property_target;
Expand Down Expand Up @@ -45,18 +42,6 @@ public class Gala.ShellWindow : PositionedWindow, GestureTarget {
);
}

private double get_hidden_progress () {
if (visible_in_multitasking_view) {
return double.min (custom_progress, 1 - multitasking_view_progress);
} else {
return double.max (custom_progress, multitasking_view_progress);
}
}

private void update_property () {
property_target.propagate (UPDATE, CUSTOM, get_hidden_progress ());
}

public override void propagate (UpdateType update_type, GestureAction action, double progress) {
switch (update_type) {
case START:
Expand All @@ -65,7 +50,11 @@ public class Gala.ShellWindow : PositionedWindow, GestureTarget {
break;

case UPDATE:
on_update (action, progress);
if (action == MULTITASKING_VIEW) {
multitasking_view_progress = progress;
}

property_target.propagate (UPDATE, CUSTOM, get_hidden_progress ());
break;

case END:
Expand All @@ -78,21 +67,8 @@ public class Gala.ShellWindow : PositionedWindow, GestureTarget {
}
}

private void on_update (GestureAction action, double progress) {
switch (action) {
case MULTITASKING_VIEW:
multitasking_view_progress = progress;
break;

case CUSTOM:
custom_progress = progress;
break;

default:
break;
}

update_property ();
protected virtual double get_hidden_progress () {
return multitasking_view_progress;
}

private void update_visibility () {
Expand Down