-
-
Notifications
You must be signed in to change notification settings - Fork 77
Introduce a first simple test #2565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f4094ed to
a16e304
Compare
a16e304 to
23a4137
Compare
23a4137 to
82a35a6
Compare
lenemter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@danirabbit since the build job now also runs the tests I renamed it to build-and-test. Would you prefer changing it back to build or can you update repository rules to require |
|
@danirabbit slight reping :) |
|
Oops thanks for pinging me again. I can update the rules 🚀 |
Requires #2564
Starting work on #2452
We have a testcase class that should be subclassed by individual tests.
Each test then should provide a main function that will run its testcase.
Lmk what you think, any feedback, etc. is very much appreciated :)
The tests are currently only run for the "build" CI should they be run for the others too?