Skip to content

Hide window actor when destroying it with reduce motion #2572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2025
Merged

Hide window actor when destroying it with reduce motion #2572

merged 2 commits into from
Oct 12, 2025

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Oct 11, 2025

Fixes #2451

We probably should implement our own animation system so we can avoid issues like this, but for now we can just do this.

@lenemter lenemter requested a review from a team October 11, 2025 20:04
leolost2605
leolost2605 approved these changes Oct 12, 2025
View reviewed changes
Copy link
Member

@leolost2605 leolost2605 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a workaround (because the actor should be destroyed and therefore not visible anymore) but since this just mimicks the behavior of it without reduce motion ig it's fine for now.

@lenemter lenemter merged commit 506b932 into main Oct 12, 2025
6 checks passed
@lenemter lenemter deleted the lenemter/hide-actor-when-destroying branch October 12, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leolost2605 leolost2605 leolost2605 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows get burned onto the screen when "Reduce Motion" is on in Secure Session

3 participants

@lenemter @leolost2605