Skip to content

lenemter/session start smooth #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
Merged

lenemter/session start smooth #2582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f41711
Use WorkspaceGestureController
lenemter Oct 18, 2025
f13ebfa
Fix
lenemter Oct 18, 2025
daa2a3f
Don't disallow reveal with barrier
lenemter Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions src/ShellClients/PanelWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ public class Gala.PanelWindow : ShellWindow, RootTarget {
hide_tracker.hide.connect (hide);
hide_tracker.show.connect (show);

workspace_gesture_controller = new GestureController (CUSTOM, wm);
workspace_gesture_controller = new GestureController (CUSTOM, wm) {
progress = 1.0
};

workspace_hide_tracker = new WorkspaceHideTracker (window.display, update_overlap);
workspace_hide_tracker.switching_workspace_progress_updated.connect ((value) => workspace_gesture_controller.progress = value);
Expand Down Expand Up @@ -119,11 +121,12 @@ public class Gala.PanelWindow : ShellWindow, RootTarget {
actor.add_action (new DragDropAction (DESTINATION, "multitaskingview-window"));
}

protected override double get_hidden_progress () {
if (starting) {
return user_gesture_controller.progress;
}
public void animate_start () {
starting = false;
workspace_hide_tracker.recalculate_all_workspaces ();
}

protected override double get_hidden_progress () {
var user_workspace_hidden_progress = double.min (
user_gesture_controller.progress,
workspace_gesture_controller.progress
Expand All @@ -139,22 +142,21 @@ public class Gala.PanelWindow : ShellWindow, RootTarget {
public override void propagate (GestureTarget.UpdateType update_type, GestureAction action, double progress) {
workspace_hide_tracker.update (update_type, action, progress);
base.propagate (update_type, action, progress);

if (starting && update_type == END && action == CUSTOM) {
// We were shown for the first time, so we can leave the special starting state
starting = false;
}
}

private void hide () {
user_gesture_controller.goto (1);
}

public void show () {
private void show () {
user_gesture_controller.goto (0);
}

private bool update_overlap (Meta.Workspace workspace) {
if (starting) {
return true;
}

var overlap = false;
var focus_overlap = false;
var focus_maximized_overlap = false;
Expand Down
6 changes: 3 additions & 3 deletions src/ShellClients/ShellClientsManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public class Gala.ShellClientsManager : Object, GestureTarget {

starting_panels = 0;
foreach (var window in panel_windows.get_values ()) {
window.show ();
window.animate_start ();
}
}
}
Expand Down Expand Up @@ -185,7 +185,7 @@ public class Gala.ShellClientsManager : Object, GestureTarget {

private void on_panel_ready (Meta.WindowActor actor) {
if (starting_panels == 0) {
panel_windows[actor.meta_window].show ();
panel_windows[actor.meta_window].animate_start ();
return;
}

Expand All @@ -194,7 +194,7 @@ public class Gala.ShellClientsManager : Object, GestureTarget {

if (starting_panels == 0) {
foreach (var window in panel_windows.get_values ()) {
window.show ();
window.animate_start ();
}
}
}
Expand Down