Skip to content

PanelWindow: calculate fullscreen overlap based on focus window #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2025
Merged

PanelWindow: calculate fullscreen overlap based on focus window #2584

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98071e0
PanelWindow: calculate fullscreen overlap based on focus window
lenemter Oct 18, 2025
71e63b3
Merge branch 'main' into lenemter/focus-fullscreen-overlap
lenemter Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/ShellClients/PanelWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public class Gala.PanelWindow : ShellWindow, RootTarget {
var overlap = false;
var focus_overlap = false;
var focus_maximized_overlap = false;
var fullscreen_overlap = false;
var focus_fullscreen_overlap = false;

Meta.Window? normal_mru_window, any_mru_window;
normal_mru_window = InternalUtils.get_mru_window (workspace, out any_mru_window);
Expand All @@ -174,22 +174,21 @@ public class Gala.PanelWindow : ShellWindow, RootTarget {

overlap = true;

fullscreen_overlap = fullscreen_overlap || window.fullscreen;

if (window != normal_mru_window && window != any_mru_window) {
continue;
}

focus_overlap = true;
focus_maximized_overlap = window.maximized_vertically;
focus_fullscreen_overlap = window.fullscreen;
}

switch (hide_mode) {
case MAXIMIZED_FOCUS_WINDOW: return focus_maximized_overlap;
case OVERLAPPING_FOCUS_WINDOW: return focus_overlap;
case OVERLAPPING_WINDOW: return overlap;
case ALWAYS: return true;
case NEVER: return fullscreen_overlap;
case NEVER: return focus_fullscreen_overlap;
}

return false;
Expand Down