Skip to content

Rely less on ShellClientsManager #2586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2025
Merged

Rely less on ShellClientsManager #2586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c6a4c8
Rely less on ShellClientsManager
lenemter Oct 19, 2025
b941b0b
Revert ShellWindow changes
lenemter Oct 19, 2025
619917b
Merge branch 'main' into lenemter/dont-rely-on-shellclientmanager
lenemter Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/DesktopIntegration.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,6 @@ public class Gala.DesktopIntegration : GLib.Object {
return false;
}

if (ShellClientsManager.get_instance ().is_positioned_window (window)) {
return false;
}

switch (window.get_window_type ()) {
case Meta.WindowType.NORMAL:
case Meta.WindowType.DIALOG:
Expand Down
18 changes: 10 additions & 8 deletions src/InternalUtils.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,17 +210,19 @@ namespace Gala {
});

foreach (var window in list) {
if (!ShellClientsManager.get_instance ().is_positioned_window (window)) {
if (any_window == null) {
any_window = window;
}
if (window.find_root_ancestor ().window_type == DOCK) {
continue;
}

if (!Utils.get_window_is_normal (window)) {
continue;
}
if (any_window == null) {
any_window = window;
}

return window;
if (!Utils.get_window_is_normal (window)) {
continue;
}

return window;
}

return null;
Expand Down
1 change: 0 additions & 1 deletion src/WindowStateSaver.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ public class Gala.WindowStateSaver : GLib.Object {
var app_id = window_tracker.get_app_for_window (window).id;

if (app_id.has_prefix ("window:") || // if window failed to be identified, don't remember it
ShellClientsManager.get_instance ().is_positioned_window (window) ||
window.window_type != Meta.WindowType.NORMAL ||
window.skip_taskbar ||
!window.resizeable ||
Expand Down