Bring back old icon groups #2595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danirabbit
approved these changes
Oct 28, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Works as expected. Also doesn't crash with dock daily which is nice because then we don't have to worry about making sure to release at the same time. Nice work!
Member
|
I pushed a daily packaging branch that sets this false and made sure to set it true for regular packaging and update recipes etc. So should be good to go there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back old icon groups and hide them behind a build flag.
I made minimal adjustments to WorkspaceClone/IconGroup code to use WindowListModel. Everything else was just copied from the old codebase.
I made sure to not change anything that's not behind a build flag so we can cleanly remove them again when we'll release new workspace switcher.
I want to do this in order to finally release a new version