Skip to content

Conversation

@leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Oct 30, 2025

  • outer_rect.width can be 0 in which case the clone_scale_factor is nan which leads to us allocating a size of nan. Therefore set the scale to 1 if the width is 0.
  • clone isn't a child of us so don't allocate it
  • bound the window title max width by its min width. The calculated max width could even be less than 0 which lead to allocating a negative size.

@leolost2605 leolost2605 requested a review from a team October 30, 2025 10:36
Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenemter lenemter enabled auto-merge (squash) November 8, 2025 17:21
@lenemter lenemter merged commit 55ff1c9 into main Nov 8, 2025
6 checks passed
@lenemter lenemter deleted the leolost/window-clone-allocate-warnings branch November 8, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants