Skip to content

WindowStateSaver: validate saved window position before placing #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+26 −1
Open

WindowStateSaver: validate saved window position before placing #2611

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c62efad
WindowStateSaver: validate saved window position before placing
lenemter Oct 30, 2025
67c2eff
Add comment
lenemter Nov 15, 2025
bd6508c
Merge branch 'main' into lenemter/wss-validate-last-position
lenemter Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/WindowStateSaver.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
*/

public class Gala.WindowStateSaver : GLib.Object {
private const double REQUIRED_AREA_PERCENTAGE_IN_BOUNDS = 5.0;

[DBus (name = "org.freedesktop.login1.Manager")]
private interface LoginManager : Object {
public signal void prepare_for_sleep (bool about_to_suspend);
Expand Down Expand Up @@ -125,7 +127,10 @@ public class Gala.WindowStateSaver : GLib.Object {
}
}

window.move_resize_frame (false, last_x, last_y, last_width, last_height);
if (validate_last_window_position (window.display, { last_x, last_y, last_width, last_height })) {
window.move_resize_frame (true, last_x, last_y, last_width, last_height);
}

track_window (window, app_id);
return;
}
Expand Down Expand Up @@ -159,6 +164,22 @@ public class Gala.WindowStateSaver : GLib.Object {
save_all_windows_state ();
}

private static bool validate_last_window_position (Meta.Display display, Mtk.Rectangle position) {
var area_in_bounds = 0;

var n_monitors = display.get_n_monitors ();
for (var i = 0; i < n_monitors; i++) {
var monitor_rect = display.get_monitor_geometry (i);

Mtk.Rectangle intersection;
monitor_rect.intersect (position, out intersection);

area_in_bounds += intersection.area ();
}

return (double) area_in_bounds / position.area () * 100.0 >= REQUIRED_AREA_PERCENTAGE_IN_BOUNDS;
}

private static void track_window (Meta.Window window, string app_id) {
window.unmanaging.connect (save_window_state);
}
Expand Down