Skip to content

Fix several interactions with disabled animations #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2025
Merged

Fix several interactions with disabled animations #2622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9989dcc
CloseButton: Follow enable-animations setting
lenemter Nov 7, 2025
07f8043
`show_tile_preview`: fix interaction with disabled animations
lenemter Nov 7, 2025
4492cb3
Merge branch 'main' into lenemter/fix-disabled-animation
lenemter Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/CloseButton.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public class Gala.CloseButton : Clutter.Actor {
}

public override bool button_press_event (Clutter.Event e) {
var estimated_duration = (uint) (ANIMATION_DURATION * (scale_x - 0.8) / 0.2);
var estimated_duration = Utils.get_animation_duration ((uint) (ANIMATION_DURATION * (scale_x - 0.8) / 0.2));

pixbuf_actor.save_easing_state ();
pixbuf_actor.set_easing_duration (estimated_duration);
Expand Down Expand Up @@ -111,7 +111,7 @@ public class Gala.CloseButton : Clutter.Actor {
}

private void reset_scale () {
var estimated_duration = (uint) (ANIMATION_DURATION * (1.0 - scale_x) / 0.2);
var estimated_duration = Utils.get_animation_duration ((uint) (ANIMATION_DURATION * (1.0 - scale_x) / 0.2));

pixbuf_actor.save_easing_state ();
pixbuf_actor.set_easing_duration (estimated_duration);
Expand Down
20 changes: 8 additions & 12 deletions src/WindowManager.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,24 +975,20 @@ namespace Gala {
unowned Meta.WindowActor window_actor = window.get_compositor_private () as Meta.WindowActor;
window_group.set_child_below_sibling (tile_preview, window_actor);

var duration = AnimationDuration.SNAP / 2U;
var duration = Utils.get_animation_duration (AnimationDuration.SNAP / 2U);

var rect = window.get_frame_rect ();
tile_preview.set_position (rect.x, rect.y);
tile_preview.set_size (rect.width, rect.height);
tile_preview.show ();

if (Meta.Prefs.get_gnome_animations ()) {
tile_preview.save_easing_state ();
tile_preview.set_easing_mode (Clutter.AnimationMode.EASE_IN_OUT_QUAD);
tile_preview.set_easing_duration (duration);
tile_preview.opacity = 255U;
tile_preview.set_position (tile_rect.x, tile_rect.y);
tile_preview.set_size (tile_rect.width, tile_rect.height);
tile_preview.restore_easing_state ();
} else {
tile_preview.opacity = 255U;
}
tile_preview.save_easing_state ();
tile_preview.set_easing_mode (Clutter.AnimationMode.EASE_IN_OUT_QUAD);
tile_preview.set_easing_duration (duration);
tile_preview.opacity = 255U;
tile_preview.set_position (tile_rect.x, tile_rect.y);
tile_preview.set_size (tile_rect.width, tile_rect.height);
tile_preview.restore_easing_state ();
}

public override void hide_tile_preview () {
Expand Down