Improve drag and drop action event consuming #2628
Open
+113
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to do this.
We don't want to consume events let alone grab the actor before we actually are sure that we will handle this drag. This will improve situations where multiple gestures can be started from the same position most notably in the multitasking view drag and drop of window clones and (once the new touchbackend is merged) swipe left and right for switching workspaces. This will also allow to use a separate click action instead of having to implement clicking in the dnd action as well.
leolost2605
force-pushed
the
leolost/drag-drop-action-dont-consume
branch
from
6dbfbd1 to
6c1b00e
Compare
lenemter
reviewed
Nov 15, 2025
Comment on lines
318
to
+319
| private bool on_event (Clutter.Event event) { | ||
| assert (dragging); |
Member
There was a problem hiding this comment.
Suggested change
| private bool on_event (Clutter.Event event) { | |
| assert (dragging); | |
| private bool on_event (Clutter.Event event) requires (dragging) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the commit message:
This will not cause any change in behavior right now because touch egg is grabbing events directly from the hardware but it will improve the behavior once our own touchscreen backend is merged and it will make things like one finger swipe up to close the window and still supporting drag and drop possible.