Skip to content

DesktopIntegration: respect reduce motion setting #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2025
Merged

DesktopIntegration: respect reduce motion setting #2639

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b8ff4d
DesktopIntegration: respect reduce motion setting
lenemter Nov 15, 2025
806cf07
Merge branch 'main' into lenemter/desktop-integration-respect-animations
lenemter Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions src/DesktopIntegration.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,19 +195,22 @@ public class Gala.DesktopIntegration : GLib.Object {
return;
}

notifying = true;

wm.get_display ().get_sound_player ().play_from_theme ("bell", _("Window has already focus"), null);
unowned var display = wm.get_display ();

#if HAS_MUTTER49
if (window.is_maximized ()) {
if (window.is_maximized () || !Meta.Prefs.get_gnome_animations ()) {
#else
if (window.get_maximized () == BOTH) {
if (window.get_maximized () == BOTH || !Meta.Prefs.get_gnome_animations ()) {
#endif
notifying = false;
// If user has "Flash screen" enabled, make sure to respect it when shake animation is not played
InternalUtils.bell_notify (display);
return;
}

display.get_sound_player ().play_from_theme ("bell", _("Window has already focus"), null);

notifying = true;

var transition = new Clutter.KeyframeTransition ("translation-x") {
repeat_count = 5,
duration = 100,
Expand All @@ -217,7 +220,7 @@ public class Gala.DesktopIntegration : GLib.Object {
transition.set_to_value (0);
transition.set_key_frames ( { 0.5, -0.5 } );

var offset = Utils.scale_to_int (15, wm.get_display ().get_monitor_scale (window.get_monitor ()));
var offset = Utils.scale_to_int (15, display.get_monitor_scale (window.get_monitor ()));
transition.set_values ( { -offset, offset });

transition.stopped.connect (() => {
Expand All @@ -230,9 +233,9 @@ public class Gala.DesktopIntegration : GLib.Object {
});

#if HAS_MUTTER48
wm.get_display ().get_compositor ().disable_unredirect ();
display.get_compositor ().disable_unredirect ();
#else
wm.get_display ().disable_unredirect ();
display.disable_unredirect ();
#endif

((Meta.WindowActor) window.get_compositor_private ()).add_transition ("notify-already-focused", transition);
Expand Down