StyleManager: get data from settings portal #2643
Open
+38
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
reviewed
Nov 15, 2025
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
My first implementation was also to get it from the portal but that only gets available after gala which seems to pose problems:
#1857 (comment)
Member
Author
|
But we use Bus.watch_name so it should be fine ig |
Member
|
Yeah I can't think of a problem caused by this rn but maybe @tintou can tell us more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why this wasn't done in the first place but this significantly simplifies StyleManager