Drop manually scaling UI elements #2662
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think we should probably weight until OS 9 because we probably will have to drop the X session completely anyways. But at least for now let's not break it intentionally 😅 |
leolost2605
added
the
Blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using 'scale monitor framebuffer' actor sizes etc. are already in logical sizes so we don't have to scale anything.
Fixes #2412
This will cause the ui elements to be too small on
Regarding X that won't be a problem in the future but I'm not sure we should already introduce regressions for X before OS 9?
Regarding without scale monitor framebuffer I would argue we should treat not having scale monitor framebuffer as unsupported. Otherwise we would still have to keep all the code for a only rarely tested code path.
Depending on other opinions on already introducing regressions for X this is blocked until OS 9.